[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] hw/misc/edu: add msi_uninit() for pci_edu_
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-trivial] [PATCH v2] hw/misc/edu: add msi_uninit() for pci_edu_uninit() |
Date: |
Mon, 14 Jan 2019 10:51:27 -0500 |
On Mon, Jan 14, 2019 at 02:28:39PM +0100, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial
>
> On 1/14/19 2:10 PM, Fei Li wrote:
> > From: Fei Li <address@hidden>
> >
> > Let's supplement the msi_uninit() when failing to realize
> > the pci edu device.
> >
> > Reported-by: Markus Armbruster <address@hidden>
> > Signed-off-by: Fei Li <address@hidden>
> > Reviewed-by: Marcel Apfelbaum <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Reviewed-by: Peter Xu <address@hidden>
> > ---
> > hw/misc/edu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> > index cdcf550dd7..ceaf688bfb 100644
> > --- a/hw/misc/edu.c
> > +++ b/hw/misc/edu.c
> > @@ -377,6 +377,7 @@ static void pci_edu_uninit(PCIDevice *pdev)
> > qemu_mutex_destroy(&edu->thr_mutex);
> >
> > timer_del(&edu->dma_timer);
> > + msi_uninit(pdev);
> > }
> >
> > static void edu_obj_uint64(Object *obj, Visitor *v, const char *name,
> >
That's not trivial material IMHO. I put it in my tree for now.
--
MST