[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs b
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] i386, acpi: cleanup build_facs by removing second unused argument |
Date: |
Wed, 30 Jan 2019 12:15:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/30/19 4:02 AM, Wei Yang wrote:
> The second argument of build_facs() is not used, just remove it.
>
> Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/acpi-build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..023729c1f2 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -292,7 +292,7 @@ static void acpi_align_size(GArray *blob, unsigned align)
>
> /* FACS */
> static void
> -build_facs(GArray *table_data, BIOSLinker *linker)
> +build_facs(GArray *table_data)
> {
> AcpiFacsDescriptorRev1 *facs = acpi_data_push(table_data, sizeof *facs);
> memcpy(&facs->signature, "FACS", 4);
> @@ -2643,7 +2643,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState
> *machine)
> * requirements.
> */
> facs = tables_blob->len;
> - build_facs(tables_blob, tables->linker);
> + build_facs(tables_blob);
>
> /* DSDT is pointed to by FADT */
> dsdt = tables_blob->len;
>