Re: [Qemu-trivial] [PATCH] ui/sdl_keysym: Remove obsolete SDL1.2 related code

[Thomas Huth]

On 2019-02-04 11:22, Daniel P. Berrangé wrote:
> On Mon, Feb 04, 2019 at 09:14:05AM +0100, Thomas Huth wrote:
>> Support for SDL1.2 has been removed recently in commit:
>>
>>   0015ca5cbabe0b31d31610ddfaafd90a9e5911a4
>>   ("ui: remove support for SDL1.2 in favour of SDL2")
>>
>> So we can drop the SDL1.2-specific code in sdl_keysym.h now, too.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  ui/sdl_keysym.h | 73 
>> ---------------------------------------------------------
>>  1 file changed, 73 deletions(-)
>>
>> diff --git a/ui/sdl_keysym.h b/ui/sdl_keysym.h
>> index 599d9fc..6994180 100644
>> --- a/ui/sdl_keysym.h
>> +++ b/ui/sdl_keysym.h
>> @@ -200,79 +200,6 @@ static const name2keysym_t name2keysym[]={
>>  { "yacute",               0x0fd},
>>  { "thorn",                0x0fe},
>>  { "ydiaeresis",           0x0ff},
>> -#if SDL_MAJOR_VERSION == 1
> 
> Don't why this was ever here, because this file is never used by SDL2.
> SDL1 passed window system native scan codes, while SDL2 always passes
> USB HID scancodes.
> 
> IOW, you can delete this whole file.

Right, seems like this file is not needed anymore. I'll send a v2...

 Thanks,
  Thomas