Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Avoid non-portable 'test -o/-a'

[Peter Maydell]

On Tue, 5 Feb 2019 at 02:46, Eric Blake <address@hidden> wrote:
>
> POSIX says that it is better to use &&/|| and two separate test
> invocations than it is to try and use -a and -o (in fact, there
> are some tests that are inherently ambiguous to parse if the
> user passes in corner-case input like "(").
>
> Since we cannot guarantee which shell runs configure, we cannot
> rely on -o/-a always following bash's parser rules.
>
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM