Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi

[Philippe Mathieu-Daudé]

Hi Wei,

On 2/13/19 7:26 AM, Wei Yang wrote:
> On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote:
>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>> There are several functions/variable which are not used anymore.
>>>>
>>>> This serials just remove those without functional change.
>>>>
>>>> v3: add ack and repost in a new thread
>>>> v2: change commit log from "is now used in no place" to "in not used 
>>>> anymore"
>>>
>>> Michael,
>>>
>>> Looks this serials is not merged yet.
>>>
>>> Is there any problem I need to fix?
>>
>> Yes pls repost with fixed reviewed-by tags.
>>
> 
> I tried to use git-sendemail to send those patches again.
> 
> The character 茅 looks good in patch file, while after git-sendemail this is
> changed.
> 
> My encoding property in mail is :
> 
>     MIME-Version: 1.0
>     Content-Type: text/plain; charset=UTF-8
>     Content-Language: en-US
>     Content-Transfer-Encoding: 8bit

I'm not sure but you can try:

      Content-Transfer-Encoding: base64

> 
> Looks the same as Philippe's.
> 
> Any hint on how to send out a correct character with git-sendemail?

If it doesn't work, then use my ASCII-reduced lastname, I can live with
that:

"Reviewed-by: Philippe Mathieu-Daude <address@hidden>"

Thanks for trying,

Phil.

> 
>>
>>>>
>>>> Wei Yang (3):
>>>>  hw/i386/pc.c: remove unused function pc_acpi_init()
>>>>  hw/acpi: remove unused function acpi_table_add_builtin()
>>>>  hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>
>>>> hw/acpi/core.c         | 10 +---------
>>>> hw/i386/pc.c           | 27 ---------------------------
>>>> include/hw/acpi/acpi.h |  1 -
>>>> include/hw/i386/pc.h   |  1 -
>>>> 4 files changed, 1 insertion(+), 38 deletions(-)