[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi
From: |
Wei Yang |
Subject: |
Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi |
Date: |
Wed, 13 Feb 2019 15:01:27 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Feb 13, 2019 at 07:32:23AM +0100, Philippe Mathieu-Daudé wrote:
>Hi Wei,
>
>On 2/13/19 7:26 AM, Wei Yang wrote:
>> On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote:
>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>> There are several functions/variable which are not used anymore.
>>>>>
>>>>> This serials just remove those without functional change.
>>>>>
>>>>> v3: add ack and repost in a new thread
>>>>> v2: change commit log from "is now used in no place" to "in not used
>>>>> anymore"
>>>>
>>>> Michael,
>>>>
>>>> Looks this serials is not merged yet.
>>>>
>>>> Is there any problem I need to fix?
>>>
>>> Yes pls repost with fixed reviewed-by tags.
>>>
>>
>> I tried to use git-sendemail to send those patches again.
>>
>> The character 茅 looks good in patch file, while after git-sendemail this is
>> changed.
>>
>> My encoding property in mail is :
>>
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Language: en-US
>> Content-Transfer-Encoding: 8bit
>
>I'm not sure but you can try:
>
> Content-Transfer-Encoding: base64
>
Looks not work.
git send-email will detect the file's encoding is 8bit, so manually change to
base64 doesn't work.
>>
>> Looks the same as Philippe's.
>>
>> Any hint on how to send out a correct character with git-sendemail?
>
>If it doesn't work, then use my ASCII-reduced lastname, I can live with
>that:
>
>"Reviewed-by: Philippe Mathieu-Daude <address@hidden>"
>
>Thanks for trying,
Thanks :-)
Let's wait a while to see whether someone else has an idea on that.
>
>Phil.
>
>>
>>>
>>>>>
>>>>> Wei Yang (3):
>>>>> hw/i386/pc.c: remove unused function pc_acpi_init()
>>>>> hw/acpi: remove unused function acpi_table_add_builtin()
>>>>> hw/acpi: remove unnecessary variable acpi_table_builtin
>>>>>
>>>>> hw/acpi/core.c | 10 +---------
>>>>> hw/i386/pc.c | 27 ---------------------------
>>>>> include/hw/acpi/acpi.h | 1 -
>>>>> include/hw/i386/pc.h | 1 -
>>>>> 4 files changed, 1 insertion(+), 38 deletions(-)
--
Wei Yang
Help you, Help me
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/02/12
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Michael S. Tsirkin, 2019/02/12
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/02/13
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/02/13
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Philippe Mathieu-Daudé, 2019/02/13
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/02/13
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/02/13
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/02/13
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/02/14
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/02/14
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Wei Yang, 2019/02/14
- Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi, Laurent Vivier, 2019/02/14