[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] gdbstub: Send a reply to the vKi
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] gdbstub: Send a reply to the vKill packet. |
Date: |
Thu, 14 Feb 2019 17:48:50 +0000 |
On Tue, 12 Feb 2019 at 21:52, Sandra Loosemore <address@hidden> wrote:
>
> Per the GDB remote protocol documentation
>
> https://sourceware.org/gdb/current/onlinedocs/gdb/Packets.html#index-vKill-packet
>
> the debug stub is expected to send a reply to the 'vKill' packet. At
> least some versions of GDB crash if the gdb stub simply exits without
> sending a reply. This patch fixes QEMU's gdb stub to conform to the
> expected behavior.
>
> Note that QEMU's existing handling of the legacy 'k' packet is
> correct: in that case GDB does not expect a reply, and QEMU does not
> send one.
>
> Signed-off-by: Sandra Loosemore <address@hidden>
Thanks, applied to target-arm.next.
As an aside, do you know if there is any kind of test suite for
the remote protocol that implementors of a debug stub can use to
check that they're conforming to it?
-- PMM