[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] trivial malloc to g_malloc in th
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] trivial malloc to g_malloc in thunk |
Date: |
Thu, 28 Feb 2019 07:59:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/28/19 7:42 AM, Aarushi Mehta wrote:
> Hi
>
> This is a trivial contribution part of the BiteSizedTasks on the wiki.
> I found this discussion
> http://git.corpit.ru/?p=qemu.git;a=commit;h=b45c03f585ea9bb1af76c73e82195418c294919d
> on migrating even g_malloc to g_new, is this not appropriate for the same?
> The wiki can presumably use an update regarding this.
>
> Signed-off-by: Aarushi <address@hidden>
> ---
> thunk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/thunk.c b/thunk.c
> index d5d8645cd4..03fb2abab7 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const
> argtype *types)
> for(i = 0;i < 2; i++) {
> offset = 0;
> max_align = 1;
> - se->field_offsets[i] = malloc(nb_fields * sizeof(int));
> + se->field_offsets[i] = g_malloc(nb_fields * sizeof(int));
Where is the counterpart free() that needs to be changed to g_free()?
Also, you absolutely want g_new() or some other variant that separates
the number of elements from the size of the element as two separate
arguments, to avoid the possibility of integer overflow when using * in
a single argument.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org