[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] trivial fix of malloc to g_ne
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk |
|
Date: |
Thu, 28 Feb 2019 10:03:37 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/28/19 9:35 AM, Aarushi Mehta wrote:
>
> Signed-off-by: Aarushi Mehta <address@hidden>
> ---
> Note that since thunking occurs throughout the lifetime of the QEMU instance,
> there is no matching 'free' to correct
This sentence is vital to the patch, so it belongs above the --- and
S-o-b as part of the commit message.
> It might be valuable to edit the BiteSizedTasks to reflect that g_new is
> favoured over g_malloc
And I've done that now, by emphasizing the discussion in HACKING (rather
than repeating it on the wiki):
https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=8247&oldid=8242
With the improved commit message,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org