[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/9] cpu/topology: add ARM suppor
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/9] cpu/topology: add ARM support for smp machine properties |
Date: |
Tue, 2 Apr 2019 05:27:32 +0000 |
On Tue, 2 Apr 2019 at 12:20, Like Xu <address@hidden> wrote:
>
> On 2019/4/2 12:45, Peter Maydell wrote:
> > My suggestion would be that we use qdev_get_machine(). I think
> > it would be nice to make the remaining dozen or so uses of
> > the global current_machine outside vl.c use qdev_get_machine()
> > instead, and then make current_machine local to vl.c instead
> > of global.
> It looks good to me and I am not sure if this refactoring should be
> added in next patch series or as a separate patch.
Changing the other uses of current_machine is definitely a
refactoring that should be a separate patch series.
thanks
-- PMM