[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qom: use object_new_with_type in
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qom: use object_new_with_type in object_new_with_propv |
Date: |
Thu, 11 Apr 2019 22:01:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 02/04/2019 08:27, Markus Armbruster wrote:
> Stefano Garzarella <address@hidden> writes:
>
>> On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote:
>>> Function object_new_with_propv already get the Type of the object, so we
>>> could leverage object_new_with_type here.
>>>
>>> [make check test pass]
>>>
>>> Signed-off-by: Wei Yang <address@hidden>
>>> ---
>>> qom/object.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> LGTM. Just a note for future patches:
>> I think that info like "[make check test pass]" should go after the
>> three dashes to avoid to store it in the commit message.
>
> Yes. Whoever applies should delete this line.
>
>> Reviewed-by: Stefano Garzarella <address@hidden>
>
> Cc: qemu-trivial for merging.
>
Applied to my trivial-patches branch with updated commit message.
Thanks,
Laurent