[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Savannah-hackers-public] switched off site-specific register/index
From: |
Assaf Gordon |
Subject: |
Re: [Savannah-hackers-public] switched off site-specific register/index |
Date: |
Mon, 26 Jun 2017 19:09:58 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi,
(adding sv-hk-public@)
On Mon, Jun 26, 2017 at 03:21:45AM -0400, Ineiev wrote:
When making i18n-specific rivision, I noticed that
in February you commented out frontend/php/register/index.php:60
with utils_get_content("register/index"); the commit log message
doesn't seem to mention this, so I wonder if that was intended
or not.
That commit (8984ae8) was only moving files from subdirectory
./frontend/php/register2/ to ./frontend/php/register/ :
commit 8984ae89ee1a98924a63f3b2ea699edb22605262
Author: Assaf Gordon <address@hidden>
Date: Sat Feb 11 19:45:37 2017 -0500
php: fix 'project registraion' directory hack (register2)
Previously, new project registration code was in
./frontend/php/register2/*.php
and an apache alias hid it with:
Alias /register /opt/savannah/savane/frontend/php/register2/
1. Removed the old,unused registration code in ./register/ .
2. moved the 3 php files from ./register2/ to ./register/ .
So every modified line looks like I modified it (with 'git blame'),
but in fact that line was commented out before (in
./frontend/php/register2/index.php).
A simple way to examine this is to checkout one commit before
said commit, then do 'git blame':
$ git checkout 8984ae^1
HEAD is now at d23caef... sv_membersh.in: improve BZR settings
$ git blame frontend/php/register2/index.php
...
18ddd313 (Sylvain Beucler 2008-03-30 17:47:33 +0200 58) } else {
18ddd313 (Sylvain Beucler 2008-03-30 17:47:33 +0200 59) # get
site-specific content
18ddd313 (Sylvain Beucler 2008-03-30 17:47:33 +0200 60) #
utils_get_content("register/index");
18ddd313 (Sylvain Beucler 2008-03-30 17:47:33 +0200 61) }
...
And based on that, I think the content file
'/etc/savane/content/gnu-content/register/index'
has not been used for a long, long time.
Hope this helps,
happy to discuss this further.
regards,
- assaf
- Re: [Savannah-hackers-public] switched off site-specific register/index,
Assaf Gordon <=