Re: [Sks-devel] expiration date now shown

[Yaron Minsky]

Is this the full patch?  It doesn't look like that could be it, since I
don't see the update to the type.  I'd be happy to add the full patch to
CVS.

y

Peter Palfrader said:
> On Thu, 18 Dec 2003, Peter Palfrader wrote:
>
>> Hi,
>>
>> If you look at
>> http://keyserver.noreply.org/pks/lookup?search=nickm%40freehaven&fingerprint=on&op=vindex
>>
>> you will see, that sks only shows the expiration date for the self sigs.
>>
>> However, some other signatures expire too, like Geoffrey's:
>> sig:::17:204C61150E606699:2003-04-10:2003-12-29:::Geoffrey L Goodell
>> <address@hidden>:10x:
>
> The problem is that SKS does not handle bit 7 of the subkey packet type:
> critical bit.
>
> This fixes it.
>
> diff -ruN sks-1.0.6-old/parsePGP.ml sks-1.0.6/parsePGP.ml
> --- sks-1.0.6-old/parsePGP.ml Sun Oct 12 22:20:19 2003
> +++ sks-1.0.6/parsePGP.ml     Thu Jan 22 12:07:56 2004
> @@ -159,7 +159,9 @@
>
>  let read_sigsubpacket cin =
>    let length = parse_sigsubpacket_length cin in
> -  let ssp_type = cin#read_byte in
> +  let ssp_type_byte = cin#read_byte in
> +  let ssp_type = ssp_type_byte land 0x7f in
> +  let ssp_critical = ssp_type_byte lor 0x80 in
>    let body = cin#read_string (length - 1) in
>    { ssp_length = length - 1;
>      ssp_type = ssp_type;
>
> Peter
> --
>  PGP signed and encrypted  |  .''`.  ** Debian GNU/Linux **
>     messages preferred.    | : :' :      The  universal
>                            | `. `'      Operating System
>  http://www.palfrader.org/ |   `-    http://www.debian.org/
> _______________________________________________
> Sks-devel mailing list
> address@hidden
> http://mail.nongnu.org/mailman/listinfo/sks-devel
>


|--------/            Yaron M. Minsky              \--------|
|--------\ http://www.cs.cornell.edu/home/yminsky/ /--------|

Open PGP --- KeyID B1FFD916
Fingerprint: 5BF6 83E1 0CE3 1043 95D8 F8D5 9F12 B3A9 B1FF D916