sks-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Sks-devel] [PATCH] IPv6 support


From: Kim Minh Kaplan
Subject: Re: [Sks-devel] [PATCH] IPv6 support
Date: Sat, 07 Mar 2009 18:26:49 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Phil Pennock:

>  * My larger patch, which opens separate sockets for each stack and
>    which adds recon6_address and hkp6_address options to sksconf if you
>    want to use a binding address other than :: (the IPv6 equivalent to
>    0.0.0.0).

I think this is the right approach except that instead of having
separate settings for IPv4 and IPv6 recon_address and hkp_address should
be extended to accept an unlimited number of names.  The db and recon
server would then bind all associated addresses.

Regarding your code it looks fine to me except that the membership part
seems overcomplicated for what it does, but I read Yaron Minsky did some
rewriting on it.

Oh, just a little nitpick: when you want to check if a list is empty
compare it to [].  The List.length function walks the whole list.

Kim Minh.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]