branch master updated: * README-hacking: update advice on configuring for compiler warnings

[Gavin D. Smith]

This is an automated email from the git hooks/post-receive script.

gavin pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new adafb67b71 * README-hacking: update advice on configuring for compiler 
warnings
adafb67b71 is described below

commit adafb67b71cccded36ace91c8babacc5d0312bb4
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Wed Oct 19 15:38:23 2022 +0100

    * README-hacking: update advice on configuring for compiler warnings
---
 ChangeLog      |  4 ++++
 README-hacking | 28 ++++++++++++++--------------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b1dd226bdd..97d2fa03c6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2022-10-19  Gavin Smith  <gavinsmith0123@gmail.com>
+
+       * README-hacking: update advice on configuring for compiler warnings
+
 2022-10-19  Gavin Smith  <gavinsmith0123@gmail.com>
 
        * tp/Texinfo/Common.pm (@variable_string_settables):
diff --git a/README-hacking b/README-hacking
index 252c5d1227..aa6c8c49e7 100644
--- a/README-hacking
+++ b/README-hacking
@@ -1,6 +1,6 @@
 This file describes the development environment for Texinfo.
 
-  Copyright 2002-2021 Free Software Foundation, Inc.
+  Copyright 2002-2022 Free Software Foundation, Inc.
 
   Copying and distribution of this file, with or without modification,
   are permitted in any medium without royalty provided the copyright
@@ -22,23 +22,13 @@ After getting the development sources, and installing the 
tools above,
 you can run
  ./autogen.sh
 and then, for example,
- ./configure -C CFLAGS='-g -Wdeclaration-after-statement'
+ ./configure -C CFLAGS='-g' PERL_EXT_CFLAGS='-g'
 and then
  make
 
 The -C tells configure to cache test results, which usually speeds
 things up a bit.
 
-That particular -W is useful because a) intermixing declarations with
-statements is an easy thing to do accidentally, b) gcc doesn't warn
-about it by default, and c) other compilers that don't support it are
-still widespread.  If you're not using gcc, of course you shouldn't
-specify that option.
-
-Other -W options can be useful too, and patches are welcome to resolve
-diagnostics; however, removing all possible warning messages, or
-warnings with nonfree compilers, is explicitly not a goal.
-
 After the initial autogen && configure, simply running make should suffice.
 
 Gettext or help2man not installed do not cause configure to fail,
@@ -226,8 +216,18 @@ NYTProf profiling for Perl code to check for avoidable 
hotspots
 try groff.texinfo from groff source repo.
 Check "make ccheck" and "make vcheck" work in "doc/refcard".
 process doc/texinfo-tex-test.texi with TeX and check that output is good.
-check for C compiler warnings by configuring with -Wall (not all have to 
-be fixed)
+check for C compiler warnings by configuring with
+
+  ./configure CFLAGS='-Wall -Wdeclaration-after-statement' \
+              PERL_EXT_CFLAGS='-Wall -Wdeclaration-after-statement'
+
+-Wdeclaration-after-statement is useful because a) intermixing
+declarations with statements is an easy thing to do accidentally,
+b) gcc doesn't warn about it by default, and c) other compilers that
+don't support it are still widespread.
+
+Not all compiler warnings have to be fixed, though.
+
 Have a look at the output of "git status -u" to check for files that
   should be tracked in git or ignored.
 make po-check             # update po/POTFILES.in as needed