branch master updated: * tp/Texinfo/XS/xspara.c (xspara_add_text) <delete END_SENTENCE>: Do not set state.last_letter, as it also set by xspara__add_next which was just called and it is confusing to have it set in two places; and the corresponding code in Texinfo::Convert::ParagraphNonXS::add_text doesn't set $paragraph->{'last_letter'}.

[Gavin D. Smith]

This is an automated email from the git hooks/post-receive script.

gavin pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new ac5d2b5dfe * tp/Texinfo/XS/xspara.c (xspara_add_text) <delete 
END_SENTENCE>: Do not set state.last_letter, as it also set by xspara__add_next 
which was just called and it is confusing to have it set in two places; and the 
corresponding code in Texinfo::Convert::ParagraphNonXS::add_text doesn't set 
$paragraph->{'last_letter'}.
ac5d2b5dfe is described below

commit ac5d2b5dfe1f3f623be77f1a5c140b9250f6f39a
Author: Gavin Smith <gavinsmith0123@gmail.com>
AuthorDate: Fri Oct 20 17:39:59 2023 +0100

    * tp/Texinfo/XS/xspara.c (xspara_add_text) <delete END_SENTENCE>:
    Do not set state.last_letter, as it also set by xspara__add_next
    which was just called and it is confusing to have it set in two
    places; and the corresponding code in
    Texinfo::Convert::ParagraphNonXS::add_text doesn't set
    $paragraph->{'last_letter'}.
---
 ChangeLog              | 9 +++++++++
 tp/Texinfo/XS/xspara.c | 1 -
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 607cb94561..37f0b347f3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2023-10-20  Gavin Smith <gavinsmith0123@gmail.com>
+
+       * tp/Texinfo/XS/xspara.c (xspara_add_text) <delete END_SENTENCE>:
+       Do not set state.last_letter, as it also set by xspara__add_next
+       which was just called and it is confusing to have it set in two
+       places; and the corresponding code in
+       Texinfo::Convert::ParagraphNonXS::add_text doesn't set
+       $paragraph->{'last_letter'}.
+
 2023-10-19  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Makefile.am (Texinfo/Commands.pm, Texinfo/Options.pm),
diff --git a/tp/Texinfo/XS/xspara.c b/tp/Texinfo/XS/xspara.c
index 615a422bdc..41af84eae2 100644
--- a/tp/Texinfo/XS/xspara.c
+++ b/tp/Texinfo/XS/xspara.c
@@ -1107,7 +1107,6 @@ xspara_add_text (char *text, int len)
               /* Otherwise reset the end of sentence marker: a full stop in
                  a string like "aaaa.bbbb" doesn't mark an end of
                  sentence. */
-              state.last_letter = wc;
               if (debug && state.end_sentence != -2)
                 fprintf (stderr, "delete END_SENTENCE(%d)\n",
                                   state.end_sentence);