acl-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tools: link libintl if discovered by AM_GNU_GETTEXT


From: Arsen Arsenović
Subject: [PATCH] tools: link libintl if discovered by AM_GNU_GETTEXT
Date: Sun, 26 Jun 2022 00:38:19 +0200

Fixes link-time errors on libcs that do not provide intl/iconv (mlibc,
for instance, only optionally does, as those are stubs)
---
Good evening,

On some systems, libc doesn't provide libintl functions. AM_GNU_GETTEXT covers
this case and generates {LT,}LIBINTL to use in linking, but attr's build system
seems to have forgotten that dependency.

Note, I haven't worked with the GNU Build System a lot in recent times, so I'm
unsure as to whether this is entirely correct (namely, I'm not entirely clear
WRT the semantics of AM_GNU_GETTEXT and how it interacts with {LT,}LIBICONV:
adding those to _ldadd seems to break on glibc, since the glibc sysroot didn't
have GNU libiconv installed, and it seems to be unconditionally set(?)).

Thanks in advance!

 tools/Makemodule.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Makemodule.am b/tools/Makemodule.am
index 890c11f..78e12b9 100644
--- a/tools/Makemodule.am
+++ b/tools/Makemodule.am
@@ -1,4 +1,4 @@
-tools_ldadd = $(LDADD) libattr.la libmisc.la
+tools_ldadd = $(LDADD) libattr.la libmisc.la @LTLIBINTL@
 
 bin_PROGRAMS += attr
 attr_SOURCES = tools/attr.c
-- 
2.35.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]