Re: [aspell-devel] Re: GNU Aspell 0.60-pre1 Now Available

[James Lee]

On 24/07/04, 13:08:27, Kevin Atkinson <address@hidden> wrote regarding Re: 
[aspell-devel] Re: GNU Aspell 0.60-pre1 Now Available:


> > (6) Arrays with no or zero length are not allowed.  These I changed
> > to be 1 element.  I have not counted what extra allocation it causes,
> > so far I've done what is needed to get a clean compile and a working
> > system.

My apologies for not listing the third occurrence of an undimensioned 
array:

--- ./modules/speller/default/readonly_ws.cpp.orig      2004-07-16 
11:22:11.000000000 -0400
+++ ./modules/speller/default/readonly_ws.cpp   2004-07-16 
11:30:54.407525000 -0400
@@ -669,7 +669,7 @@
     byte sl_size;
     byte data_size;
     byte flags;
-    char word[];
+    char word[1];
   };
 
   struct SoundslikeLess {




> > (7) There is an ambiguity as to whether "log(double)" or "log(long
> > double)" should be used in ./common/convert.cpp.  This is because the
> > args of the call are integer and it's not clear whether the implicit
> > type cast should be to double or long double.  I type cast as double.
> >
> > -    int sz = 1 << (unsigned)floor(log(size <= 1 ? 1 : size -
> > 1)/log(2.0));
> > +    int sz = 1 << (unsigned)floor(log((double) (size <= 1 ? 1 : size -
> > 1))/logx(2.0));

> Does "size <= 1 ? 1.0 : size - 1" work OK?  That how I changed it.

Yes.




James Lee.