[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [AUCTeX-devel] not advising hack-one-local-variable

From: Ralf Angeli
Subject: Re: [AUCTeX-devel] not advising hack-one-local-variable
Date: Thu, 20 Oct 2005 10:46:05 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

* Dave Love (2005-10-19) writes:

> tex.el shouldn't use advice on `hack-one-local-variable'.  My session
> got into a bad state when this went wrong somehow and all local
> variable processing broke.  (I'm not sure how.)

That's not a really compelling reason to remove the advice.  It would
be good to know what exactly went wrong and why.  Maybe the advice is
not the problem or you'd get the same breakage with your proposal.

> This patch possibly DTRT, but I'm not sure the feature should be
> present, since you can specify minor modes in local variables if you
> must

Yes, but this won't call the minor mode function.

> and this AUCTeX feature doesn't seem to be documented.  (I know
> it's a deficiency that `mode:' in local variables actually toggles
> minor modes rather than switching them on.)

That's how we see it.  But obviously Richard does not share this view.

> The patch is against v11.81, though I tested it in Debian's 1.55.  I
> haven't tested under XEmacs, but the hook is present there, so I
> assume it will work.

I looked at the patch and it looks very similar to the patch I
originally proposed in
<URL:>.  Two days after
that message I checked in the version with the advice.  Unfortunately
I don't remember why I dumped the proposal with the hook.

Having checked your proposal it seems to work.  But as
functionality-wise it is mostly equivalent to the dumped patch I am
still a bit reluctant to check it in.  I'd like to know more about the
problem with the advice.

> [Glancing at the current FAQ, I'm surprised at the advice to use
> development Emacs 22.  Most times I try an update of it I find some
> new regression,

Not in my case.  At least I don't have the impression that anything is
going downhill.

> and the response to bug reports is disheartening :-(.

Really?  I think, taking the manpower behind Emacs development in
concern the bug reporting list is quite responsive.  And if a bug
report remains unanswered for some days usually Richard takes care of
it and reminds people.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]