[AUCTeX-devel] Re: AUCTeX tool-bar and icons

[Ralf Angeli]

* Reiner Steib (2008-05-14) writes:

> On Wed, May 14 2008, Ralf Angeli wrote:
>
>> * Angelo Graziosi (2008-05-14) writes:
>>
>>> Then : 'new-file' does not appear,
>>
>> Perhaps we should remove the `new-file' option again.  
>
> Do you refer to my recent change?  It just change the custom
> interface, so it's not relevant to Angelo's report using setq.

Well, there is no entry in `toolbarx-default-toolbar-meaning-alist'
corresponding to `new-file'.  So if it is offered in
`TeX-bar-LaTeX-buttons', the implementation should be added.

>> With GTK I don't see a difference between `find-file' and
>> `menu-find-file-existing'.  And there is no equivalent in Emacs 21.
>
> We should not refrain from improving the tool bar just to make it
> identical under Emacs 21.

Sure.  But the stuff should at least work in Emacs 21.  Ideally we'd
also not have no-ops or identical functionality under different names.

>>> 'open-file' has as icon the same 
>>> which Emacs uses for 'new-file',
>>
>> Because clicking the button will actually call the function used by
>> Emacs for opening a new file.
>
> I think this is a bug in toolbar-x.  I'd suggest this patch (no
> compatibility code for Emacs 21 added, since I can't test it):
>
> --- toolbar-x.el      10 May 2008 22:03:00 +0200      1.18
> +++ toolbar-x.el      14 May 2008 22:13:41 +0200      
> @@ -1974,14 +1974,21 @@
>  
>  (defconst toolbarx-default-toolbar-meaning-alist
>    '((separator :image "sep" :command t :enable nil :help "")
> -    (open-file :image ["new" toolbar-file-icon]
> +    (new-file :image ["new" toolbar-file-icon]
[...]
> +    (open-file :image ["open" toolbar-file-icon]

So on XEmacs both entries will mean the same.

> +            :command [menu-find-file-existing toolbar-open]

I just played a bit with `find-file' and `menu-find-file-existing' and
the distinction looks rather artificial to me, so I would not bother if
we did not support the latter.

> BTW, I don't think that duplication tool tips, images, etc. is a good
> idea.

Me neither.

> I'd rather use something like Gnus `gmm-tool-bar-zap-list', but
> I'm biased, of course (warning: there's no XEmacs compatibility
> there).

If we dropped XEmacs compatibility we'd not have a need for toolbar-x
anymore.  This is not the worst option in my opinion.

>>> 'dired' is represented by the icon 
>>> which Emacs uses for 'open-file',
>>
>> Yes, because there is no image for this in Emacs 21.
>
> When using Emacs 21, the user won't miss the icon in AUCTeX.  So we
> don't need to care about the missing image.  Using the wrong image is
> confusing.

Can we perhaps make the `dired' option available only on platforms which
have the respective image?  Providing the option and then doing nothing
or throwing an error when it is used is not so good.

-- 
Ralf