[AUCTeX-devel] Re: [AUCTeX-diffs] Changes to reftex/lisp/reftex-cite.el, v

[David Kastrup]

A performance issue.

Ralf Angeli <address@hidden> writes:

> CVSROOT:      /sources/auctex
> Module name:  reftex
> Changes by:   Ralf Angeli <angeli>    08/06/07 11:16:58
>
> Index: reftex-cite.el
> ===================================================================
> RCS file: /sources/auctex/reftex/lisp/reftex-cite.el,v
> retrieving revision 1.49
> retrieving revision 1.50
> diff -u -b -r1.49 -r1.50
> --- reftex-cite.el    7 Jun 2008 09:05:32 -0000       1.49
> +++ reftex-cite.el    7 Jun 2008 11:16:57 -0000       1.50
> @@ -1158,21 +1158,15 @@
>      (reftex-kill-temporary-buffers)
>      keys))

> +  (reftex-remove-if (lambda (x) (or (string-match "^[\"{]" x)
> +                                 (string-match "^[0-9]+$" x)))
> +                 ;; get list of values, discard keys

I think it could be better to use a single string-match with
alternatives here: that way the regexp cache gets utilized better.


-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum