[AUCTeX-devel] Re: pstricks.el

[Holger Sparr]

Ralf Angeli wrote:
> * David Kastrup (2009-01-21) writes:
>
>> How shall we proceed with regard to putting pstricks.el in?  Holger, do
>> you want to have CVS write access, or would you prefer it if somebody
>> else placed the code into the repository?  If there are frequent changes
>> and/or bug fixes, it makes most sense if the person doing the work is
>> also the one checking it in.
>
> Before checking it in we should do a basic review.  Glancing over it I
> saw the following issues:
>
> * Lines are too long

Adjusted.

> * `C-c <letter>' key bindings violate major mode conventions

Changed to 'C-c C-x C-'.

> * There is a lot of interning going on (I haven't checked why and if
>   this is really necessary)
> * There are some functions not prefixed with `LaTeX-pst' which look like
>   they serve a more general purpose

The interning goes generally with the functions named differently and
are used by some other lisp-style-files (like pst-...) too.

>From my point of view I can check in the pstricks.el.

Any objections?

Holger

--