[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [AUCTeX-devel] imakeidx.el and a patch for latex.el

From: Tassilo Horn
Subject: Re: [AUCTeX-devel] imakeidx.el and a patch for latex.el
Date: Fri, 28 Dec 2012 23:50:29 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

"address@hidden" <address@hidden> writes:

>> You're welcome.  Could you provide one and implement the alist2list
>> conversion in imakeidx.el like suggested in my last mail?  Then I'm
>> happy to commit.
> I'm sending fixed `imakeidx.el' and patch to `latex.el' (the same as the 
> previous one).
> This is the entry for ChangeLog (I hope it's OK):
> 2012-12-28  Mosè Giordano  <address@hidden>
>       * latex.el (LaTeX-pagestyle-list): New variable.
        (TeX-arg-pagestyle): Use it.

The entry for TeX-arg-pagestyle is missing.  (Something like the above.)

Just a bit more nitpicking:

> ;; `firstpagestyle' and `headers' options for `indexsetup' macro are
> ;; available only if `fancyhdr' is not loaded.  The following code
> ;; works only if `imakeidx' is loaded before `fancyhdr'
> (unless (member "fancyhdr" TeX-active-styles)
>   ;; `firstpagestyle' key takes as value one of the available
>   ;; pagestyles.  `LaTeX-pagestyle-list' is a list of lists of
>   ;; strings, we need a list of strings
>   (setq LaTeX-imakeidx-firstpagestyle-values
>         (mapcar #'car LaTeX-pagestyle-list))

You shouldn't create new global variables just with setq.  If
`LaTeX-imakeidx-firstpagestyle-values' is supposed to be a global
variable, defvar it.  (I don't see why it needs to be a global

>   (setq LaTeX-imakeidx-indexsetup-options
>       (append LaTeX-imakeidx-indexsetup-options
>               '(("firstpagestyle" LaTeX-imakeidx-firstpagestyle-values))
>               '(("headers")))))

You change the global value of LaTeX-imakeidx-indexsetup-options here.
I think, LaTeX-imakeidx-indexsetup-options should be buffer-local, I
mean, I can work with one document using imakeidx and fancyhdr, and one
with imakeidx but without fancyhdr, right?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]