[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [AUCTeX-devel] fancyhdr.el + fancynum.el
From: |
Tassilo Horn |
Subject: |
Re: [AUCTeX-devel] fancyhdr.el + fancynum.el |
Date: |
Wed, 13 Feb 2013 20:34:36 +0100 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) |
Hi Mads,
I've committed fancynum.el.
But there are some nitpicks wrt. fancyhdr.el. Please fix those and send
an improved patch.
- `fancyhdr-fancy-positions' is used only in one position, so no need to
have a defvar for it. Also, if the variable was needed, it should
have a name matching the conventions, e.g.,
`LaTeX-fancyhdr-fancy-positions'.
- Now that the parser supports pagestyles, you should add the fancy and
fancyplain pagestyles provided by fancyhdr. See
`LaTeX-add-pagestyles'.
- `TeX-arg-fancyhdr-position': The first line of the docstring should be
one complete sentence. I suggest "Promt for a fancyhdr position."
You should also document all arguments. Have a look at the other
TeX-arg-* functions.
Bye,
Tassilo