Re: [AUCTeX-devel] A bug in TeX-clean?

[Tassilo Horn]

Marcin Borkowski <address@hidden> writes:

Hi Marcin,

> here's a fragment of the TeX-clean function in tex.el:
>
> ,----
> | (regexp (concat "\\("
> |                      (regexp-quote (file-name-nondirectory master)) "\\|"
> |                      (TeX-region-file nil t)
> |                      "\\)"
> |                      "\\("
> |                      (mapconcat 'identity suffixes "\\|")
> |                      "\\)\\'"
> |                      "\\|" (TeX-region-file t t)))
> `----
>
> Shouldn't the call to TeX-region-file be wrapped in regexp-quote, too,
> just in case the user changes TeX-region to something strange?

Yes, indeed.  Fixed in Git.

> And while at it, why not use shy groups?

No specific reason.  Shy groups match a bit faster but here speed is not
important, so normal groups are maybe a bit nicer on the eyes.

Bye,
Tassilo