Re: [AUCTeX-devel] [PATCH 2/2] New style pdfpages.el.

[Arash Esbati]

Mosè Giordano <address@hidden> writes:

Hi Mosè,

> 2015-06-05 23:01 GMT+02:00 Arash Esbati <address@hidden>:
>> Hi all,
>>
>> this patch adds support for `pdfpages.sty'.  Many thanks to Andreas
>> Matthias for testing this style.
>
> Both patches installed, thank you!

Thanks for installing them and sorry for my late response; I was AFK
this week.

> Probably in "pdfpages.el" we should set (TeX-master-directory) as the
> default directory for `file-relative-name', right?

Thanks for your comment.  I looked at `graphicx.el' and I agree that we
should set (TeX-master-directory).  Further, I think it also makes sense
to narrow down the alternatives offered to pdf files only.  I can
imagine of a change like this:

--8<---------------cut here---------------start------------->8---
   (TeX-add-symbols
    ;; \includepdf[<options>]{<filename>}
    '("includepdf"
      [TeX-arg-key-val LaTeX-pdfpages-key-val-options]
      (TeX-arg-eval
       (lambda ()
         (let ((pdffile (file-relative-name
                         (read-file-name
                          "File to include: " nil nil nil nil
                          (lambda (pdfs)
                            (string-match "\\.pdf$" pdfs)))
                         (TeX-master-directory))))
           (format "%s" pdffile)))))
--8<---------------cut here---------------end--------------->8---

It is basically the same as `LaTeX-includegraphics-read-file-relative',
but I dropped the `(or (file-directory-p fname) ...' since I'm not sure
if it makes sense for this use case.

Any comment?

Best, Arash