Re: [AUCTeX-devel] Beginnings of TikZ support

[Matthew Leach]

Mosè Giordano <address@hidden> writes:

> Hi Matt,

Hi Mosè

> a few random comments.

Thanks for taking a look.

> The file lacks the footer.  To automatically insert it run M-x
> checkdoc RET.  In addition, this function will suggest you some
> changes to docstrings.  Apart from those referring to "_ignored"
> arguments, most of them are valuable, please consider applying them.

Ah, I didn't know about `checkdoc', useful!  I've fixed the issues it
has raised and committed.

> I use a lot the syntaxes "(node) -- +(new-node)" and "(node) --
> ++(new-node)"  (see section 2.1 Specifying Coordinates of TikZ
> manual), it'd be nice to have them as well :-)  

I have a patch for this, but I'm not too sure about it as it uses a
function from dash.el, namely -mapcat.  I'm not sure if this will break
the xemacs build.

> Instead, I don't know what "-+" is supposed to do, neither I can find
> in the manual.

Indeed I can't find it in the manual either; I don't know where I picked
that up from.  I've removed that.

> In addition, regarding completion in `TeX-TikZ-get-arg-type' I'd make
> it case-insensitive unless there is a good reason against doing so,
> just let-bind `completion-ignore-case' to t.

Agreed, committed.

> I believe that the "official" name for the text next to nodes is
> "label" (this is the name used throughout the manual, the name of the
> option when you set the label in optional arguments, and if the label
> is missing the error thrown is "A node must have a (possibly empty)
> label text.") instead of "text".  I'd stick with usual TikZ
> terminology.

Good spot.  I'll change the terminology used in the style.

> Good job so far!

Thanks :-).
-- 
Matt