auctex-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [AUCTeX-devel] bidi patch


From: Mosè Giordano
Subject: Re: [AUCTeX-devel] bidi patch
Date: Sat, 17 Sep 2016 18:28:20 +0200

2016-09-17 18:14 GMT+02:00 Uwe Brauer <address@hidden>:
>    > In addition, the patch installs two useless files, please pay more
>    > attention when you submit patches.
>
> What useless files? could you please clarify?

Did you take a look to the file you sent?

--8<---------------cut here---------------start------------->8---
[...]

diff --git a/export.patch b/export.patch
new file mode 100644
--- /dev/null
+++ b/export.patch
@@ -0,0 +1,126 @@

[...]

diff --git a/export2.patch b/export2.patch
new file mode 100644
--- /dev/null
+++ b/export2.patch
@@ -0,0 +1,125 @@

[...]

--8<---------------cut here---------------end--------------->8---

> Here is what I do (and it worked flawlessly for emacs-matlab, but there
> I merge and I can push and pull since I have write access to the repo in
> question):

It's not a matter of workflow, or git, or hg-git, you committed two
patches files lying in your workspace.  That would be an error even
with hg ;-)

> Ok sorry. I thought opeing new threads is helpful :-D.

I have to read two or more threads to discover where the latest
version of patch is and of which patch.  If you don't open a new
thread for each patch or to tell to ignore another patch I can just
read your latest message with an attachment in order to review a
specific patch.  A thread named "patch with improved commit message"
doesn't really tell me what the patch is about, and I have to read the
thread to find whether it's the latest version of the patch for
style/bidi.el (and discover that it is not).  Please stick with one
thread per patch.

Bye,
Mosè



reply via email to

[Prev in Thread] Current Thread [Next in Thread]