Re: [AUCTeX-devel] Call for patches for last release on 11.x series

[David Kastrup]

Arash Esbati <address@hidden> writes:

> Mosè Giordano <address@hidden> writes:
>
>> 2017-11-10 18:42 GMT+01:00 David Kastrup <address@hidden>:
>>> Uwe Brauer <address@hidden> writes:
>>>
>>>> Ok, what's about styles? Could those go in the future in both branches,
>>>> in master in the 11.92-old or whatever the name of the branch will be??
>>>
>>> The point of stopping development for XEmacs is not to increase the
>>> workload.
>>
>> Yes, we don't want to port any new feature --- including style files
>> --- to the then frozen 11.x series.
>
> +1.
>
>>> I'd recommend not making a branch but a _tag_ for the last
>>> version known to work with XEmacs to make unambiguously clear that the
>>> AUCTeX developers are not responsible for working on an XEmacs version
>>> any more.
>>
>> For sure we'll just tag release_11_92 for the time being.  I think
>> that we reserve the possibility to create a branch if it'll be
>> necessary to port important bug fixes to 11.x series, but this can be
>> decided later.
>
> I'm also in favor of this version.  We have a situation right now that
> the current master is not really compatible with XEmacs and older
> Emacsen because of the `delete-dups' usage here and there.  I think we
> should create a new branch and add a compatibility function there.  Can
> we use the one from Emacs 25.3 and just rename it to `TeX-delete-dups'?
>
> (defun delete-dups (list)
>   "Destructively remove `equal' duplicates from LIST.
> Store the result in LIST and return it.  LIST must be a proper list.
> Of several `equal' occurrences of an element in LIST, the first
> one is kept."
>   (let ((l (length list)))
>     (if (> l 100)
>         (let ((hash (make-hash-table :test #'equal :size l))
>               (tail list) retail)
>           (puthash (car list) t hash)
>           (while (setq retail (cdr tail))
>             (let ((elt (car retail)))
>               (if (gethash elt hash)
>                   (setcdr tail (cdr retail))
>                 (puthash elt t hash)
>                 (setq tail retail)))))
>       (let ((tail list))
>         (while tail
>           (setcdr tail (delete (car tail) (cdr tail)))
>           (setq tail (cdr tail))))))
>   list)

I'm pretty sure I created an efficient version of delete-dups (didn't
use a hash table but rather some algorithm based on sorting) for RefTeX
at one point of time.  Can we use that?

Have I committed it?

-- 
David Kastrup