Re: algpseudo.patch

[Tassilo Horn]

Uwe Brauer <oub@mat.ucm.es> writes:

Hi Uwe,

> Add support for algopseudocde style
>
> * Makefile.in (STYLESRC): Add  algopseudocde style
>
> * style/algpseudocode.el: Add support for the algopseudocde (algorithmcx) 
> style

Please use the GNU ChangeLog conventions here, e.g., wrap around that
long line.

> diff -r ab505643f81b -r 5a22e1099c05 Makefile.in
> --- a/Makefile.in     Sun Jun 07 21:24:43 2020 +0900
> +++ b/Makefile.in     Sun Jun 07 22:55:40 2020 +0200
> @@ -172,7 +172,7 @@
>          style/changelog.el style/ltugboat.el  style/beamerswitch.el \
>          style/multitoc.el  style/fbox.el      style/xkcdcolors.el \
>          style/ltxguide.el  style/revtex4-2.el style/overpic.el \
> -        style/tex-live.el
> +        style/tex-live.el  style/algpseudocode.el \
                                                     ^

There's nothing on the next line so no need for the \.

> +(declare-function font-latex-add-keywords
> +               "font-latex"
> +               (keywords class))

You don't use that function, so you can remove that forward declaration.

Other than that, the patch looks fine, I think.

Bye,
Tassilo