Re: Output filenames and the inconsistency of the `file` variable

[Ikumi Keita]

Hi Al,

>>>>> Al Haji-Ali <abdo.haji.ali@gmail.com> writes:
> Ah I see. Then I guess we can simply have this change.

> diff --git a/tex.el b/tex.el
> index 9a1d1b6d..9a9e574f 100644
> --- a/tex.el
> +++ b/tex.el
> @@ -1165,7 +1165,7 @@ entry in `TeX-view-program-list-builtin'."
>                                  (get-file-buffer (TeX-region-file t)))
>                                (current-buffer))
>         (pdf-sync-forward-search))
> -    (let ((pdf (concat file "." (TeX-output-extension))))
> +    (let ((pdf (TeX-active-master (TeX-output-extension))))
>        (pop-to-buffer (or (find-buffer-visiting pdf)
>                          (find-file-noselect pdf))))))

> @@ -1189,7 +1189,7 @@ viewer."
>    (require 'url-util)
>    (let* ((uri (concat "file://" (url-encode-url
>                                  (expand-file-name
> -                                 (concat file "." (TeX-output-extension))))))
> +                                 (TeX-active-master 
> (TeX-output-extension))))))
>          (owner (dbus-call-method
>                  :session (format "org.%s.%s.Daemon" de app)
>                  (format "/org/%s/%s/Daemon" de app)

It looks good to me and the modified TeX-evince-sync-view-1 wokrs for my
atril actually.

> Another change that I want to suggest (for the same reason) is the
> following in `tex-buf.el`:

> diff --git a/tex-buf.el b/tex-buf.el
> index ff6be7e6..62913f86 100644
> --- a/tex-buf.el
> +++ b/tex-buf.el
> @@ -82,7 +82,7 @@ Return non-nil if document needs to be re-TeX'ed."
>    (if (string-equal name "")
>        (setq name (TeX-master-file)))

> -  (TeX-check-files (concat name "." (TeX-output-extension))
> +  (TeX-check-files (TeX-active-master (TeX-output-extension))
>                    (cons name (TeX-style-list))
>                    TeX-file-extensions))

> @@ -826,7 +826,7 @@ omitted) and `TeX-region-file'."
>            ;; comparison.
>            (if (string-equal (expand-file-name name)
>                              (expand-file-name (TeX-region-file)))
> -              (TeX-check-files (concat name "." (TeX-output-extension))
> +              (TeX-check-files (TeX-active-master (TeX-output-extension))
>                                 ;; Each original will be checked for all dirs
>                                 ;; in `TeX-check-path' so this needs to be 
> just
>                                 ;; a filename without directory.

On the other hand, I don't understand the intention of this proposal. In
both cases, the variable `name' is properly defined as a function
argument of TeX-save-document and TeX-command-default, respectively. So
I don't see point in using TeX-active-master here. Am I missing
something?

> Also, if these changes are acceptable, should I create a pull request
> with them on the gitlab AUCTeX repository? Or is posting the diffs
> here sufficient?

The latter. I don't know gitlab AUCTeX repo, perhaps it is an unoffical
mirror?

Regards,
Ikumi Keita