auctex-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: font-latex-match-warning-make void function.


From: Ikumi Keita
Subject: Re: font-latex-match-warning-make void function.
Date: Fri, 26 Mar 2021 23:47:16 +0900

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Attached is a possible solution. Stefan, is it safe to repeat the same
>> `advice-add' or `advice-remove'? That is,

> Yes, they're idempotent.

>> Experiments seem to suggest that it's safe. But if not, I have to add
>> `advice-member-p' test.

> Not needed.

Thank you, I can now be confident.

>> diff --git a/tests/tex/path-expansion.el b/tests/tex/path-expansion.el
>> index 2246e92ca8..f19c331965 100644
>> --- a/tests/tex/path-expansion.el
>> +++ b/tests/tex/path-expansion.el
>> @@ -25,6 +25,7 @@
>> 
>> (ert-deftest TeX-variable-truncation ()
>> "Check whether list variable is not truncated as side effect."
>> +  (defvar var)
>> (let ((var '("str1" "str2"))
>> (TeX-kpathsea-path-delimiter nil)
>> (TeX-search-files-type-alist

> This is going in the right direction but the byte-compiler should
> hopefully tell you that this is not quite sufficient: please also rename
> `var` to add some namespace prefix to it (I suggest `TeX--var`).

Well, this is a piece of regresstion test suits and the variable in
question is used only within this particular `ert-deftest'. So I
presumed it's OK. Is this presumtion wrong?

Regards,
Ikumi Keita



reply via email to

[Prev in Thread] Current Thread [Next in Thread]