Re: [Autobuild-discuss] About current Autobuild version

[Julien ÉLIE]

Hi Simon,

>> Would it be possible to commit the current version used in
>> <http://autobuild.josefsson.org/>?
>> Or, even better, release a new official version?
> 
> Oops.  The online version and the software in git has forked for some
> reason.  I have now commited the version running to the git repository,
> and we can fix future bugs in that.  It seems to have better support for
> different modes.

OK, many thanks!

For what is worth, I am a bit worried by the following changes in Git:

1/
-           $status = "almost" if m,\d+ of \d+ tests? failed,;
+           $status = "almost" if m,\d+ of \d+ tests failed,;

I thought adding "?" was done to fix a bug when only 1 test is run.


2/
My patch for skipping trailing commas has been removed.
Here is a new one, including modes:

--- ../autobuild/autobuild      2011-08-29 08:23:40.000000000 +0200
+++ ./autobuild 2011-08-29 09:06:21.000000000 +0200
@@ -403,27 +403,41 @@
 }
 
 foreach $project (sort keys %Projects) {
+    my $count;
+
     print "<hr />\n";
     print "<h2><a name=\"$project\">Project '$project'</a></h2>\n";
     print "\n";
     print "<p>Revisions (" . keys(%{$Revisions{$project}}) . "): ";
+    $count = 0;
     foreach $revision (reverse sort { if ($a eq $b) { return 0; } else { my $i 
= 0; do { my $j = substr ($a, $i, 1); my $k = substr ($b, $i, 1); if ($j != $k) 
{ $j = substr ($a, $i); $k = substr ($b, $i); return $j <=> $k; } $i++; } while 
($i < length($a)); } } keys %{$Revisions{$project}}) {
-       print "<a href=\"#$project-$revision\">$revision</a>, ";
+       print ", " if $count;
+       print "<a href=\"#$project-$revision\">$revision</a>";
+       $count++;
     }
     print "</p>\n";
-    print "<p>Hosttypes (" . keys(%{$Hosttypes{$project}}) . "): ";
+    print "<p>Host types (" . keys(%{$Hosttypes{$project}}) . "): ";
+    $count = 0;
     foreach $hosttype (sort keys %{$Hosttypes{$project}}) {
-       print "<a href=\"#$project-$hosttype\">$hosttype</a>, \n";
+       print ", " if $count;
+       print "<a href=\"#$project-$hosttype\">$hosttype</a>\n";
+       $count++;
     }
     print "</p>\n";
     print "<p>Build hosts (" . keys(%{$Hostnames{$project}}) . "): ";
+    $count = 0;
     foreach $hostname (sort keys %{$Hostnames{$project}}) {
-       print "<a href=\"#$project-$hostname\">$hostname</a>, \n";
+       print ", " if $count;
+       print "<a href=\"#$project-$hostname\">$hostname</a>\n";
+       $count++;
     }
     print "</p>\n";
     print "<p>Modes (" . keys(%{$Modes{$project}}) . "): ";
+    $count = 0;
     foreach $mode (sort keys %{$Modes{$project}}) {
-       print "<a href=\"#$project-$mode\">$mode</a>, \n";
+       print ", " if $count;
+       print "<a href=\"#$project-$mode\">$mode</a>\n";
+       $count++;
     }
     print "</p>\n";
 



-- 
Julien ÉLIE

« Le cercle est le plus long chemin d'un point au même point. »
  (Tom Stoppard, _Every Good Boy Deserves Favour_)