Re: [Autobuild-discuss] Homogenize column titles

[Julien ÉLIE]

Hi Simon,

> As for revision vs version I fully agree. Let's use 'Version' 
> everywhere.

Shouldn't the m4 macro for Autobuild be changed?
It mentions "autobuild revision".
It would be better to have the same wording everywhere.

The "--revision" flag to Autobuild should then also be renamed to "--version".



> System: name of machine doing the build
> 
> Build type: Type of the "system" machine, e.g.
> x86_64-unknown-linux-gnu.
> 
> Host type: Type the build is for, when you are cross-compiling, e.g.,
> i686-pc-linux-gnu
> 
> Are these names ok?  Maybe use 'Hostname' instead of 'System'?  Or
> 'Machine'?

I think "Host name" is the easiest to understand.



> Based on this, maybe you could rework your patch? I think we want 
> different columns for build type and host type and system name,
> although I'm not sure those are the best terms.

Why would "build type" and "host type" be in a different column?

They are concatenated into the same column in the code:

                    if ($hosttype eq $Buildtype) {
                        print "</td>\n";
                    } else {
                        print " from $Buildtype</td>\n";
                    }



Here is a suggestion of patch.  Please do not hesitate to adjust changes
if you think the title is not the right one.


--- /home/iulius/scripts/autobuild/bin/autobuild.OLD2   2011-08-29 
09:30:12.000000000 +0200
+++ /home/iulius/scripts/autobuild/bin/autobuild        2011-08-29 
09:44:17.000000000 +0200
@@ -324,8 +324,8 @@
     print "<td>Project</td>\n";
     print "<td>Build type</td>\n";
     print "<td>Mode</td>\n";
-    print "<td>Revision</td>\n";
-    print "<td>System</td>\n";
+    print "<td>Version</td>\n";
+    print "<td>Host name</td>\n";
     print "<td>Build date</td>\n";
     print "<td>Results</td>\n";
     print "</tr>\n\n";
@@ -426,7 +426,7 @@
     print "<hr />\n";
     print "<h2><a name=\"".tokenizeAnchor($project)."\">Project 
'$project'</a></h2>\n";
     print "\n";
-    print "<p>Revisions (" . keys(%{$Revisions{$project}}) . "): ";
+    print "<p>Versions (" . keys(%{$Revisions{$project}}) . "): ";
     $count = 0;
     foreach $revision (reverse sort { if ($a eq $b) { return 0; } else { my $i 
= 0; do { my $j = substr ($a, $i, 1); my $k = substr ($b, $i, 1); if ($j != $k) 
{ $j = substr ($a, $i); $k = substr ($b, $i); return $j <=> $k; } $i++; } while 
($i < length($a)); } } keys %{$Revisions{$project}}) {
         print ", " if $count;
@@ -442,7 +442,7 @@
         $count++;
     }
     print "</p>\n";
-    print "<p>Build hosts (" . keys(%{$Hostnames{$project}}) . "): ";
+    print "<p>Host names (" . keys(%{$Hostnames{$project}}) . "): ";
     $count = 0;
     foreach $hostname (sort keys %{$Hostnames{$project}}) {
         print ", " if $count;
@@ -468,9 +468,9 @@
        print "\n";
        print "<table border=\"0\">\n";
        print "<tr bgcolor=\"lightblue\">\n";
-       print "<td>System</td>\n";
+       print "<td>Build type</td>\n";
        print "<td>Mode</td>\n";
-       print "<td>Build host</td>\n";
+       print "<td>Host name</td>\n";
        print "<td>Build date</td>\n";
        print "<td>Results</td>\n";
        print "</tr>\n";
@@ -539,10 +539,10 @@
        print "\n";
        print "<table border=\"0\">\n";
        print "<tr bgcolor=\"lightblue\">\n";
-       print "<td>Revision</td>\n";
+       print "<td>Version</td>\n";
        print "<td>Cross?</td>\n";
        print "<td>Mode</td>\n";
-       print "<td>Build host</td>\n";
+       print "<td>Host name</td>\n";
        print "<td>Build date</td>\n";
        print "<td>Results</td>\n";
        print "</tr>\n";
@@ -613,7 +613,7 @@
        print "<table border=\"0\">\n";
        print "<tr bgcolor=\"lightblue\">\n";
        print "<td>Version</td>\n";
-       print "<td>System</td>\n";
+       print "<td>Build type</td>\n";
        print "<td>Mode</td>\n";
        print "<td>Build date</td>\n";
        print "<td>Results</td>\n";
@@ -683,9 +683,9 @@
        print "\n";
        print "<table border=\"0\">\n";
        print "<tr bgcolor=\"lightblue\">\n";
-       print "<td>System</td>\n";
-       print "<td>Build host</td>\n";
-       print "<td>Revision</td>\n";
+       print "<td>Build type</td>\n";
+       print "<td>Host name</td>\n";
+       print "<td>Version</td>\n";
        print "<td>Build date</td>\n";
        print "<td>Results</td>\n";
        print "</tr>\n";




-- 
Julien ÉLIE

« Le cercle est le plus long chemin d'un point au même point. »
  (Tom Stoppard, _Every Good Boy Deserves Favour_)