[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Small fix to testsuite
From: |
Raja R Harinath |
Subject: |
Re: Small fix to testsuite |
Date: |
31 Oct 2000 12:13:44 -0600 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 |
Pavel Roskin <address@hidden> writes:
> Hello Raja!
>
> > Here's a small fix to the testsuite for srcdir != builddir.
>
> Fine with me, although I don't know whether it actually fixes any problem
> or not.
It does. The actual fix was to change
autoconf --autoconf-dir $top_srcdir
to
autoconf --autoconf-dir ..
since autoconf wants the .m4f file, which is in the build tree. It
removes one failing testcase in a non-srcdir build.
While at it, I made the autoconf invocation agree with every other
autoconf invocation in the file.
> If you want consistency the right way to go would be probably to define a
> variable like this:
>
> at_autoconf="autoconf --autoconf-dir .. -l $at_srcdir"
>
> and use it everywhere across the tests.
That is a bigger patch, and independent of this fix. I could send it
in if you want.
- Hari
--
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions." -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing." -- Roy L Ash