Re: FYI: 7-gary-_AC_FEATURE_CHECK_LENGTH-break-3.patch

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Albert Chin wrote:
| On Wed, Apr 21, 2004 at 04:31:27PM -0700, Paul Eggert wrote:
|
|>Albert Chin <address@hidden> writes:
|>
|>
|>>On Wed, Apr 21, 2004 at 02:03:36PM +0100, Gary V. Vaughan wrote:
|>>
|>>>Applied to HEAD.
|>>
|>>Why? Is it _safe_ to assume how deeply nested we are?
|>
|>My impression is that he was just trying to patch the problem without
|>trying to come up with a more-general solution.  _AS_PATH_WALK is
|>documented to be poorly-designed, and _AC_PATH_PROG_FEATURE_CHECK is
|>inheriting that poor design.  It'd be nice to fix the overall problem,
|>of course.
|
|
| Part of this patch removed the break from _AC_PATH_PROG_FEATURE_CHECK:
|   http://mail.gnu.org/archive/html/autoconf-patches/2004-03/msg00026.html

Unfortunately, the patch doesn't work for the reasons I gave in:
~  http://mail.gnu.org/archive/html/autoconf-patches/2004-04/msg00051.html

Gary V. Vaughan wrote:
| ...we can't
| break out of the nested for loops just as soon as ac_cv_path_$1 is set
| because the while loop in _AC_FEATURE_CHECK_LENGTH keeps setting it every
| time it finds a better $ac_path_$1.  Breaking out early would find the
| first tool, rather than the best.

Using break like I have does suck though.  I guess we could set another flag
to decide when a suitable tool has been found.  I'll post a patch presently.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAh4W6FRMICSmD1gYRAjSMAKC5KaWQ8HK08X4UJNu3QSjz8iENRACgkezW
M2jdyq9/JTg4CEr+fGBZ+xA=
=2DjI
-----END PGP SIGNATURE-----