Re: cvs build prob

[Paul Eggert]

"Gary V. Vaughan" <address@hidden> writes:

> Good catch!  I'm CCing the autoconf list, as this is probably a candidate for
> AS_SHELL_SANITIZE, and the comparative shellology documentation...

Thanks.  I installed the patch enclosed below.

>> Reminder of the miscreant line:
>> 
>>   output_verbose_link_cmd="`$echo \"X$output_verbose_link_cmd\" | $Xsed -e 
>> \"$no_glob_subst\"`"

The workaround in this case is easy.  Just omit the outer quotes and
remove the inner backslashes:

output_verbose_link_cmd=`$echo "X$output_verbose_link_cmd" | $Xsed -e 
"$no_glob_subst"`

The outer quotes aren't needed.  This issue is discussed in the
Autoconf manual's Shellology section.

Anyway, here's the Autoconf patch I installed.

2004-07-27  Paul Eggert  <address@hidden>

        * lib/m4sugar/m4sh.m4 (_AS_BOURNE_COMPATIBLE): Use "set -o posix"
        with pdksh, too.  Problem reported by Patrick Welche via
        Gary V. Vaughan.
        * doc/autoconf.texi (Shellology): Note that set -o posix is
        useful for pkdsh, too.

Index: doc/autoconf.texi
===================================================================
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.822
diff -p -u -r1.822 autoconf.texi
--- doc/autoconf.texi   4 Jun 2004 20:40:33 -0000       1.822
+++ doc/autoconf.texi   27 Jul 2004 20:11:08 -0000
@@ -9366,8 +9366,8 @@ Substitutions}, item ``Command Substitut
 
 @item Bash
 @cindex Bash
-To detect whether you are running @command{bash}, test if
address@hidden is set.  To disable its extensions and require
+To detect whether you are running @command{bash}, test whether
address@hidden is set.  To require
 @acronym{POSIX} compatibility, run @samp{set -o posix}.  @xref{Bash POSIX
 Mode,, Bash @acronym{POSIX} Mode, bash, The @acronym{GNU} Bash Reference
 Manual}, for details.
@@ -9407,6 +9407,9 @@ not have it.
 A public-domain clone of the Korn shell called @samp{pdksh} is also
 widely available: it has most of the @samp{ksh88} features along with
 a few of its own.
+Similarly to @command{bash}, you can detect whether you are running
address@hidden by testing whether @code{KSH_VERSION} is set, and you can
+require @acronym{POSIX} compatibility by running @samp{set -o posix}.
 
 @item Zsh
 @cindex Zsh
Index: lib/m4sugar/m4sh.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.117
diff -p -u -r1.117 m4sh.m4
--- lib/m4sugar/m4sh.m4 24 Jun 2004 15:00:30 -0000      1.117
+++ lib/m4sugar/m4sh.m4 27 Jul 2004 20:11:08 -0000
@@ -162,7 +162,7 @@ if test -n "${ZSH_VERSION+set}" && (emul
   # is contrary to our usage.  Disable this feature.
   alias -g '${1+"address@hidden"}'='"address@hidden"'
   setopt NO_GLOB_SUBST
-elif test -n "${BASH_VERSION+set}" && (set -o posix) >/dev/null 2>&1; then
+elif test -n "${BASH_VERSION+set}${KSH_VERSION+set}" && (set -o posix) 
>/dev/null 2>&1; then
   set -o posix
 fi
 DUALCASE=1; export DUALCASE # for MKS sh