[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Introduce TESTSUITE_FLAGS
From: |
Noah Misch |
Subject: |
Re: Introduce TESTSUITE_FLAGS |
Date: |
Sun, 19 Dec 2004 01:19:30 -0800 |
User-agent: |
Mutt/1.5.6i |
On Sat, Dec 18, 2004 at 12:08:27PM +0100, Alexandre Duret-Lutz wrote:
> On Sat, Dec 18, 2004 at 02:09:45AM -0800, Noah Misch wrote:
> > +EXTRA_DIST = testsuite.at testsuite atlocal.in
> EXTRA_DIST = testsuite.at $(TESTSUITE) atlocal.in
>
> The problem is that as soon as `$(srcdir)/foo' is used in some
> dependency or target of a Makefile, it should be spelled this way
> everywhere else. Otherwise BSD make gets confused.
GNU `make' seems to be alone in that regard.
Updated patch:
2004-12-19 Noah Misch <address@hidden>
* tests/Makefile.am (installcheck-local): Use $(bindir).
(check-local, installcheck-local): Pass TESTSUITEFLAGS.
* doc/autoconf.texi (Making testsuite Scripts): Recommend the same
Makefile.am scheme Autoconf now uses.
diff -urp -X dontdiff ac-clean/doc/autoconf.texi ac-ts_flags/doc/autoconf.texi
--- ac-clean/doc/autoconf.texi 2004-12-15 02:29:03.000000000 -0500
+++ ac-ts_flags/doc/autoconf.texi 2004-12-18 05:06:03.252195958 -0500
@@ -15614,10 +15614,14 @@ With Automake, here is a minimal example
check} with a validation suite.
@example
-EXTRA_DIST = testsuite.at testsuite
+EXTRA_DIST = testsuite.at $(TESTSUITE) atlocal.in
TESTSUITE = $(srcdir)/testsuite
+
check-local: atconfig atlocal $(TESTSUITE)
- $(SHELL) $(TESTSUITE)
+ $(SHELL) $(TESTSUITE) $(TESTSUITEFLAGS)
+
+installcheck-local: atconfig atlocal $(TESTSUITE)
+ $(SHELL) $(TESTSUITE) AUTOTEST_PATH="$(bindir)" $(TESTSUITEFLAGS)
AUTOTEST = $(AUTOM4TE) --language=autotest
$(TESTSUITE): $(srcdir)/testsuite.at
diff -urp -X dontdiff ac-clean/tests/Makefile.am ac-ts_flags/tests/Makefile.am
--- ac-clean/tests/Makefile.am 2004-12-10 13:10:37.000000000 -0500
+++ ac-ts_flags/tests/Makefile.am 2004-12-18 05:06:24.294020591 -0500
@@ -116,11 +116,11 @@ clean-local:
rm -f -r autom4te.cache
check-local: atconfig atlocal $(TESTSUITE)
- $(SHELL) $(TESTSUITE)
+ $(SHELL) $(TESTSUITE) $(TESTSUITEFLAGS)
# Run the test suite on the *installed* tree.
installcheck-local: atconfig atlocal $(TESTSUITE)
- $(SHELL) $(TESTSUITE) AUTOTEST_PATH=$(exec_prefix)/bin
+ $(SHELL) $(TESTSUITE) AUTOTEST_PATH="$(bindir)" $(TESTSUITEFLAGS)