Re: PATCH: silence ash during shell search

[Stepan Kasal]

Hello Paul,
  you checked in the following patch:

On Fri, Dec 24, 2004 at 11:51:33PM -0800, Paul Eggert wrote:
> --- m4sh.m4   21 Dec 2004 14:24:01 -0000      1.128
> +++ m4sh.m4   25 Dec 2004 07:49:41 -0000      1.129
> @@ -228,10 +228,12 @@ if test "x$CONFIG_SHELL" = x; then
>         esac])
>  
>        for as_shell in $as_candidate_shells $SHELL; do
> -      AS_IF([_AS_RUN([_AS_DETECT_REQUIRED_BODY], [$as_shell 2> /dev/null])],
> +      AS_IF([_AS_RUN([_AS_DETECT_REQUIRED_BODY],
> +                        [($as_shell) 2> /dev/null])],
>              [CONFIG_SHELL=$as_shell
>              as_have_required=yes
> -            AS_IF([_AS_RUN([_AS_DETECT_SUGGESTED_BODY], [$as_shell 2> 
> /dev/null])],
> +            AS_IF([_AS_RUN([_AS_DETECT_SUGGESTED_BODY],
> +                           [($as_shell) 2> /dev/null])],
>                    [break])])
>        done
>  

I think the second change is not necessary, the patch posted originally is
enough.  The problem was that the default shell reported
        foo: not found
even when you called
        foo 2>/dev/null

Once you found the shell in the first commmand, I see now way how the bug
could hit again in the test for ``suggested'' features.

I see, the difference is almost zero, but I couldn't resist when I noticed it.

Yours,
        Stepan