[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AT Macro to Log a File on Failure
|
From: |
Alexandre Duret-Lutz |
|
Subject: |
Re: AT Macro to Log a File on Failure |
|
Date: |
Wed, 29 Dec 2004 19:15:05 +0100 |
|
User-agent: |
Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) |
>>> "Noah" == Noah Misch <address@hidden> writes:
[...]
Noah> address@hidden AT_CAPTURE_FILE (@var{file})
Noah> address@hidden
Noah> +If the current test group fails, log the contents of @var{file}. M4
Noah> +expands macros in @var{file}, and the shell expands the result within
Noah> +double quotes to craft the name of the file to log. Several identical
Noah> +calls within one test group have no additional effect.
[...]
The rest of the patch looks good to me, but I'd suggest you omit
(or reword) the second sentence in this description. When I
first read it I though that the contents of the `file' file
would be processed by M4! IMHO we do not need document
arguments that are processed with M4, because that is the rule.
--
Alexandre Duret-Lutz