Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR

[Gary V. Vaughan]

Hi Paul,

Paul Eggert wrote:
> I like the patch from the Autoconf point of view, assuming the Automake
> folks take their bit.

Thanks.

> One small point:
>
> "Gary V. Vaughan" <address@hidden> writes:
>
>
>>+ac_libobj_dir=
>>+test "X${ac_config_libobj_dir-.}" != X. &&
>>+  ac_libobj_dir=`echo "$ac_config_libobj_dir/" | sed 's,/*$,/,'`
>
>
> That would mishandle the case where ac_config_libobj_dir consists
> entirely of slashes, or if it contains weird characters like
> backslashes or newlines in unusual positions.  Is this possible?  If
> so, how about something like this to avoid the problem?
>
> ac_libobj_dir=
> test "X${ac_config_libobj_dir-.}" != X. &&
>   ac_libobj_dir=`expr "X$ac_config_libobj_dir/" : 'X\(.*[^/]\)' '|' 'X/' : 
> 'X\(/\)'`

I think that does something different.  The idea of my sed expression is
just to avoid adding a trailing slash if configure.ac contains, say,
AC_CONFIG_LIBOBJ_DIR([lib/]).

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature