[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A small simplification
From: |
Stepan Kasal |
Subject: |
Re: A small simplification |
Date: |
Thu, 19 May 2005 09:22:13 +0200 |
User-agent: |
Mutt/1.4.1i |
Hello,
on a second thought, I think I was completely wrong here:
> > > I guess we cannot have
> > > echo " " >confdefs.h
> > > because a smart editor might replace the spaces with tabs.
Autoconf sources, configure and config.status contain whitespace
which has to be preserved. (The [<tab><space>]* regular expressions
in config header sed scripts are an example.)
The confdefs.h initialization is not special.
Thus I believe there is no problem with the patch below.
OK to commit?
Stepan
2005-05-19 Stepan Kasal <address@hidden>
* ./lib/autoconf/general.m4 (_AC_INIT_PREPARE): Simplify the initial
echo to confdefs.h .
Index: ./lib/autoconf/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/general.m4,v
retrieving revision 1.856
diff -u -r1.856 general.m4
--- ./lib/autoconf/general.m4 17 May 2005 09:29:05 -0000 1.856
+++ ./lib/autoconf/general.m4 19 May 2005 07:20:31 -0000
@@ -1290,8 +1290,7 @@
rm -f -r conftest* confdefs.h
# AIX cpp loses on an empty file, so make sure it contains at least a newline.
# NextStep 3.3 (patch 3) loses unless the first echo outputs at least 14 bytes.
-ac_space=' '
-echo
"$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space$ac_space"
>confdefs.h
+echo " " >confdefs.h
# Predefined preprocessor variables.
AC_DEFINE_UNQUOTED([PACKAGE_NAME], ["$PACKAGE_NAME"],