[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Last configure args
From: |
Paul Eggert |
Subject: |
Re: Last configure args |
Date: |
Fri, 20 May 2005 12:18:46 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
>> That "EMACS=t" is bogus; can you fix it somehow?
>
> I don't think it's bogus. Autoconf looks for EMACS. It's exactly what
> `./config.status --recheck' will set as well (with or without my patch),
> if the original `configure' was called from within emacs.
OK, thanks, it's a bit weird I guess, but that's consistent.
>> 4. The documentation change could be tightened up a bit. How about
>> this instead? But it needs a further improvement: a brief explanation
>> as to why the two commands are equivalent.
>
> Would a cross reference to the corresponding section suffice, or
> do you think we need to explain how shell quoting works?
A cross reference is enough.
> +eval `./config.status --config`
> +./config.status --recheck && ./config.status
This doesn't look right to me. Shouldn't the argument to eval be
quoted? E.g.,
eval "`./config.status --config`"
Otherwise, if the output of config.status contains (say) a "*", it
might get expanded. (However, perhaps I'm wrong: please see below.)
> +set x `./config.status --config`
> +shift; shift
> +./configure "$@@" CFLAGS='-g'
Hmm, this won't work in general if the output contains "*".
Perhaps it would be better to leave the documentation alone and
fix the code, as follows:
> +ac_cs_configure="$[0]"
> +ac_cs_config="`echo "$ac_configure_args" | sed 's/[[\\""\`\$]]/\\\\&/g'`"
Quote all shell metacharacters, not just \"\$. Hmm, but how will you
handle newlines?