[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix and optimize _AC_COMPUTE_INT_COMPILE
From: |
Paul Eggert |
Subject: |
Re: Fix and optimize _AC_COMPUTE_INT_COMPILE |
Date: |
Wed, 07 Sep 2005 14:02:19 -0700 |
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) |
Stepan Kasal <address@hidden> writes:
* lib/autoconf/general.m4 (_AC_COMPUTE_INT_COMPILE): Do not use
"break" in the parameters to _AC_COMPILE_IFELSE; reorganize the
code, so that _AC_COMPILE_IFELSE is called only once.
Wow, what a (ahem) clever patch!
A couple things. First, since most hosts are two's complement, it's
better to start off with a test < 0 rather than a test > 0, since the
former test neatly divides the possible values into two equal-sized
parts. Could you rewrite it to do that? (This may force you to
recheck the code, which is probably a good thing here...)
Second, a minor thing:
case $ac_lo:$ac_hi in
:* | *:) ;;
*)
...
esac
This is slightly clearer:
case $ac_lo:$ac_hi in
?*:?*)
...
esac