autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix AT_SETUP's sh-escaping


From: Paul Eggert
Subject: Re: fix AT_SETUP's sh-escaping
Date: Wed, 08 Nov 2006 22:00:56 -0800
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

"Joel E. Denny" <address@hidden> writes:

> However, I get FAILED for 67 (Backslash in a test title).  Here's an 
> update to your patch that fixes it:

By inspection I noticed some other bugs in that area.  The shell
quoting was wrong (unportable) in several places; I suppose this might
explain the failure symptoms on other platforms.  I installed this:

2006-11-08  Ralf Wildenhues  <address@hidden>
        and Joel E. Denny  <address@hidden>
        and Paul Eggert  <address@hidden>

        * tests/autotest.at (AT_CHECK_AT_TITLE): Fix shell quoting bugs
        and non-portable sed scripts, and use $CONFIG_SHELL when invoking
        ./micro-suite.

--- tests/autotest.at   27 Oct 2006 23:05:34 -0000      1.18
+++ tests/autotest.at   9 Nov 2006 05:56:48 -0000
@@ -257,14 +257,15 @@ AT_SETUP([$2])
 AT_CHECK([:])
 AT_CLEANUP
 ]], [$4], [], [], [],
-[AT_CHECK([[./micro-suite | sed -n "s/[^:]*: \(.*[^ \t]\)[ \t]*ok.*/\1/p"]],,
+[AT_CHECK([[$CONFIG_SHELL ./micro-suite |
+           sed -n 's/[^:]*: \(.*[^      ]\)[    ]*ok.*/\1/p']],,
 [[$3
 ]])
-AT_CHECK([[./micro-suite -l \
-             | sed -n "s/.*[0-9]\+: [^ \t]\+[ \t]\+\(.*[^ \t]\)[ \t]*/\1/p"]],,
+AT_CHECK([[$CONFIG_SHELL ./micro-suite -l |
+          sed -n 's/.*[0-9]: [^         ][^     ]*[     ][      ]*\(.*[^       
 ]\)[    ]*/\1/p']],,
 [[$3
 ]])
-AT_CHECK([[sed -n "s/[^.]*\. \(.*\) ([^)]*): ok.*/\1/p" micro-suite.log]],,
+AT_CHECK([[sed -n 's/[^.]*\. \(.*\) ([^)]*): ok.*/\1/p' micro-suite.log]],,
 [[$3
 ]])
 ])])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]