Re: Patch proposal: Add --clean options to unbootstrap a project.

[Benoit Sigoure]

Quoting Ralf Wildenhues <address@hidden>:

> Hello Benoit,
>
> * Benoit Sigoure wrote on Tue, Jun 19, 2007 at 12:17:07AM CEST:
> > +      system ('rm -rf autom4te.cache');
>
> Ah, one bit that is not general: the name of the cache directory may be
> customized, see `(autoconf.info)Customizing autom4te'.  I suppose a nice
> and clean implementation would have `autom4te --clean' and let
> autoreconf invoke that.  It in turn would remove the cache directory
> only if caching was enabled and a relative path, but rather not with an
> absolute path.
>
> Apologies for not stumbling over that in my last review.

After going through the code of autoconf, autoheader and aclocal  
(which seem to be the only toold to directly invoke autom4te) I can't  
see how one could change the cache directory.  Ah yes, there is not  
work around: env AUTOM4TE='autom4te --cache=/some/where'.  I highly  
doubt this would ever happen and would it ever do, I think the user  
(who obviously knows what he is doing) would not like to remove his  
own cache.  Moreover it would be fragile because he would have to  
invoke autoreconf --clean with the same environment variable.

> > --- lib/Autom4te/FileUtils.pm   17 May 2006 02:17:58 -0000      1.12
> > +++ lib/Autom4te/FileUtils.pm   18 Jun 2007 22:06:55 -0000
>
> This file needs a copyright year update.

Oops, yes.

> Other than that, the patch looks good to me.
>
> Cheers, and thanks for all your work on this,

Thanks for reviewing it.

New patch attached with the two minor nits noticed above corrected.  I  
haven't done anything WRT `rm -fr autom4te.cache'.

2007-06-17  Benoit Sigoure  <address@hidden>

        * bin/autoconf.as, bin/autoheader.in, bin/autoreconf.in: New option
        `--clean'.
        * NEWS: Mention it.
        * bin/autoreconf.in (&run_make): New.
        (&autoreconf_current_directory): Use it.  Honor the $clean variable.
        * lib/Autom4te/General.pm ($clean): New boolean value.
        (getopt): Handle `--clean'.
        * lib/Autom4te/FileUtils.pm ($SIMPLE_BACKUP_SUFFIX): Export it.
        * tests/torture.at: Test the new feature.
        * doc/autoconf.texi (autoconf Invocation, autoreconf Invocation,
        autoheader Invocation): Document the new option.

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

autoconf-bootclean.patch
Description: Text document