Re: AC_C_BIGENDIAN answers "universal" on powerpc-aix

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Peter O'Gorman on 8/14/2008 3:52 PM:
> On Thu, Aug 14, 2008 at 10:43:21PM +0200, Ralf Wildenhues wrote:
>> * Peter O'Gorman wrote on Thu, Aug 14, 2008 at 08:04:20PM CEST:
>>> On Thu, Aug 14, 2008 at 07:16:58PM +0200, Ralf Wildenhues wrote:
>>>> (Hereby volunteering to do my part in it in the next 48 hours,
>>>> but please others do test as well if possible).
>>> I will test on aix, i386-darwin, and i386-linux
> 
> I think this one addresses your nits.

Two other nits:

> +#if defined AC_APPLE_UNIVERSAL_BUILD

This name means that since AC_[A-Z]* is now expected to appear in
configure, it should trip the m4_pattern_forbid of the autoconf m4
namespace as a potentially unexpanded macro (I wonder why it didn't seem
to trip in your testing?).  Why not just strip the AC_ prefix, and go with
the name APPLE_UNIVERSAL_BUILD?

> +#  define WORDS_BIGENDIAN 1

Not quite right, since this is for an autoheader template.  In the
AH_VERBATIM, it should look like the instance four lines later:

> +#  undef WORDS_BIGENDIAN

and let config.status do the conversion to the desired state in both
locations.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkilBz4ACgkQ84KuGfSFAYApJwCdGBSttpXg7eY9DzxKmcXLS2Zw
OrQAoK+WajOiovd6vNgCe6YlmqaU/gKV
=6Tw+
-----END PGP SIGNATURE-----