Re: [PATCH] Ditch _AS_LINENO_PREPARE from _AS_PREPARE

[Paolo Bonzini]

>>  # m4_pattern_allow(ERE)
>>  # ---------------------
>>  # ... that token also matches the allowed extended regular expression ERE.
>>  # Both used via traces.
>> -m4_define([m4_pattern_allow], [])
>> +m4_define([m4_pattern_allow], [_$0([\b$1\b], m4_shift($@))])
>> +m4_define([_m4_pattern_allow], [])
> 
> Independent of your patch, but at least the m4sugar side of this ought to
> mention the use of a second parameter as the warning issued when this is
> encountered.

Yes, the documentation part was seriously deficient...

> Also, your use of m4_shift always produces a second
> argument, even if m4_pattern_allow was only called with one; does the
> trace-parsing side of autom4te treat an empty argument the same as a
> missing one?

I don't know.  It's a rather different purpose of
m4_pattern_forbid/allow, and I feared it needed more Perl hacking that I
didn't really want to get muddled in; so that's why I sent out the patch
(mostly for inspiration).

Paolo