autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63-


From: Eric Blake
Subject: Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63-156-gbc6676e
Date: Tue, 04 Nov 2008 19:14:52 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 11/4/2008 2:32 PM:

Hi Ralf, and thanks for keeping me honest,

>>     Reject arguments with leading =.
>>     
> 
> Any chance for a testsuite update?

Sure.

> 
> Is maybe the Autotest testsuite too slow/complicated/unwieldy/whatever
> to be used more?

No, just laziness on my part, in copying something from autotest where the
autotest patch already had coverage in the testsuite.  I did test it
manually, though.

I'm pushing this followup, to automate my manual tests:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkRAZwACgkQ84KuGfSFAYBz6gCfTMNNbQPRtLnzTKqHrAUgCiUc
HQoAnjkX1mJbzbIf0n69YNKUkhngnQGC
=j0x1
-----END PGP SIGNATURE-----
>From 62c045085d9f128160af18cf4fd07f8a6dce60ce Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Tue, 4 Nov 2008 19:13:38 -0700
Subject: [PATCH] Reject arguments with leading =; test previous patch.

* tests/base.at (configure arguments): Test this.
Reported by Jeff Squyres.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog     |    1 +
 tests/base.at |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f54b453..c658e67 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -7,6 +7,7 @@
        * lib/autoconf/status.m4 (_AC_OUTPUT_CONFIG_STATUS)
        (_AC_OUTPUT_MAIN_LOOP): Quote invalid arguments.
        * lib/autotest/general.m4 (AT_INIT): Likewise.
+       * tests/base.at (configure arguments): Test this.
        Reported by Jeff Squyres.
 
 2008-11-04  Eric Blake  <address@hidden>
diff --git a/tests/base.at b/tests/base.at
index 883db25..1ed8e1c 100644
--- a/tests/base.at
+++ b/tests/base.at
@@ -321,6 +321,10 @@ AT_CHECK_AUTOCONF
 AT_CHECK_CONFIGURE([FOO=bar --enable-baz --without-zork --silent], [0], 
[stdout], [ignore])
 AT_CHECK([grep 'FOO=bar --enable-baz --without-zork --silent' stdout], [0], 
[ignore], [ignore])
 
+dnl check that syntax error is detected
+AT_CHECK_CONFIGURE([=], [1], [], [ignore], [ignore])
+AT_CHECK_CONFIGURE([1=2], [1], [], [ignore], [ignore])
+
 AT_CLEANUP
 
 
-- 
1.6.0.2


reply via email to

[Prev in Thread] Current Thread [Next in Thread]