Re: [PATCH] Pass CONFIG_SHELL down if provided

[Ralf Wildenhues]

Hello Paolo,

* Paolo Bonzini wrote on Thu, Oct 30, 2008 at 02:59:49PM CET:
> Subconfigures are invoked with $SHELL, not with $CONFIG_SHELL.  And
> config.status is also created with
> 
> #! $SHELL
> 
> which will not pick the CONFIG_SHELL if it was given by the user on the
> command line.  So is this patch correct?

> 2008-10-30  Paolo Bonzini  <address@hidden>
> 
>       * lib/m4sugar/m4sh.m4 (_AS_DETECT_BETTER_SHELL): Pass
>       CONFIG_SHELL down to generated scripts if it was provided.
> 
> diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4
> index 8bb0bef..372f042 100644
> --- a/lib/m4sugar/m4sh.m4
> +++ b/lib/m4sugar/m4sh.m4
> @@ -265,6 +265,8 @@ Then install a modern shell, or manually run the
> script under such a
>  shell if you do have one.], [$[]0: ], [], [62])")
>    fi
>        AS_EXIT(1)])])
> +else
> +  SHELL=$CONFIG_SHELL
>  fi

Not sure about this one.  It is not wrong to pass SHELL down, but
typically, inside the generated scripts you still won't be able to rely
on its value.  config.status for example is called from Makefiles as
well, not just from configure.

Or maybe I have misunderstood the intent of this patch?

Thanks!
Ralf